[performance] optimize ES|QL async polling #243104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewdaemon
added
the
Team:DataDiscovery
drewdaemon
force-pushed
the
optimize-esql-polling-requests
branch
from
7dd46a3 to
aba08ef
Compare
drewdaemon
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
drewdaemon
commented
Nov 18, 2025
|
|
||
| let optimizedParams = request.params; | ||
|
|
||
| if (strategy === ESQL_ASYNC_SEARCH_STRATEGY) { |
Contributor
Author
There was a problem hiding this comment.
@lukasolson curious to hear your thoughts on treating the strategies differently here. Another option would be to add a new optimizeParamsForPoll method to the strategies themselves which would keep the logic together with the strategy.
Contributor
There was a problem hiding this comment.
Do we actually need anything inside params if we're polling? Could we do something like this?
Contributor
Author
There was a problem hiding this comment.
I pushed a slight variant of your patch. Let's see what CI does.
drewdaemon
force-pushed
the
optimize-esql-polling-requests
branch
from
a368263 to
b99c505
Compare
Contributor
💚 Build Succeeded
Metrics [docs]Page load bundle
History
|
jbudz
added a commit
to jbudz/kibana
that referenced
this pull request
Nov 20, 2025
This reverts commit a72addd.
jbudz
added a commit
that referenced
this pull request
Nov 20, 2025
Checking for build failures seen in https://buildkite.com/elastic/kibana-on-merge/builds/82173. May be unrelated, failing tests were not propagating previously - see #243499
andrimal
pushed a commit
to andrimal/kibana
that referenced
this pull request
Nov 20, 2025
andrimal
pushed a commit
to andrimal/kibana
that referenced
this pull request
Nov 20, 2025
…lastic#243586) Checking for build failures seen in https://buildkite.com/elastic/kibana-on-merge/builds/82173. May be unrelated, failing tests were not propagating previously - see elastic#243499
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #242601